lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Sep 2013 14:51:57 +0200 From: Miklos Szeredi <miklos@...redi.hu> To: viro@...IV.linux.org.uk Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, mszeredi@...e.cz, Eric Van Hensbergen <ericvh@...il.com>, stable@...r.kernel.org Subject: [PATCH 03/11] 9p: fix O_EXCL in v9fs_vfs_atomic_open() From: Miklos Szeredi <mszeredi@...e.cz> If open flags has O_EXCL and dentry is positive after lookup then return -EEXIST instead of "1". This bug resulted in some O_EXCL opens succeeding (on a cache miss) despite the file already existing. Signed-off-by: Miklos Szeredi <mszeredi@...e.cz> Cc: Eric Van Hensbergen <ericvh@...il.com> Cc: stable@...r.kernel.org --- fs/9p/vfs_inode.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 94de6d1..915cea5 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -863,8 +863,15 @@ v9fs_vfs_atomic_open(struct inode *dir, struct dentry *dentry, } /* Only creates */ - if (!(flags & O_CREAT) || dentry->d_inode) + if (!(flags & O_CREAT)) { return finish_no_open(file, res); + } else { + err = -EEXIST; + if (flags & O_EXCL) + goto out; + + return finish_no_open(file, res); + } err = 0; fid = NULL; -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists