lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1379338078.2718.19.camel@menhir>
Date:	Mon, 16 Sep 2013 14:27:58 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	viro@...IV.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, mszeredi@...e.cz
Subject: Re: [PATCH 09/11] gfs2: set FILE_CREATED

Hi,

On Mon, 2013-09-16 at 14:52 +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> In gfs2_create_inode() set FILE_CREATED in *opened.
> 
Acked-by: Steven Whitehouse <swhiteho@...hat.com>

Thanks for spotting this issue,

Steve.


> Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
> Cc: Steven Whitehouse <swhiteho@...hat.com>
> ---
>  fs/gfs2/inode.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 9a1be62..ef411a3 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -694,8 +694,10 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
>  
>  	mark_inode_dirty(inode);
>  	d_instantiate(dentry, inode);
> -	if (file)
> +	if (file) {
> +		*opened |= FILE_CREATED;
>  		error = finish_open(file, dentry, gfs2_open_common, opened);
> +	}
>  	gfs2_glock_dq_uninit(ghs);
>  	gfs2_glock_dq_uninit(ghs + 1);
>  	return error;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ