linux-kernel - Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo6475cSMDtdk2ywFUUyb_szOFVdUy9Pm0DjnRTuiCVPhw@mail.gmail.com>
Date:	Mon, 16 Sep 2013 07:40:25 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Kent Overstreet <koverstreet@...gle.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Jens Axboe <axboe@...nel.dk>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Gu Zheng <guz.fnst@...fujitsu.com>
Subject: Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free

On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet
<koverstreet@...gle.com> wrote:
> On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote:
>> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
>> > This fixes a copy and paste error introduced by 9f060e2231
>> > ("block: Convert integrity to bvec_alloc_bs()").
>> >
>> > Found by Coverity (CID 1020654).
>> >
>> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
>> > ---
>> >  fs/bio-integrity.c |    2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
>> > index 8fb4291..45e944f 100644
>> > --- a/fs/bio-integrity.c
>> > +++ b/fs/bio-integrity.c
>> > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
>> >                 mempool_destroy(bs->bio_integrity_pool);
>> >
>> >         if (bs->bvec_integrity_pool)
>> > -               mempool_destroy(bs->bio_integrity_pool);
>> > +               mempool_destroy(bs->bvec_integrity_pool);
>> >  }
>> >  EXPORT_SYMBOL(bioset_integrity_free);
>>
>> Kent, do you want to chime in on this?  Looks like an obvious error to
>> me, but maybe I'm missing something and we should teach Coverity to
>> shut up about it.
>
> Sorry - no, this is definitely a bug:
>
> Acked-by: Kent Overstreet <koverstreet@...gle.com>

>From my v3.12-rc1 reminder list: what's going on with this patch?

It's been acked, Gu asked whether he could include it in some
patchset, I see a Sep 11 2013 patch from Gu upstream already
(bc5c8f078), but this patch (from May 29 2013) still hasn't gone
anywhere.  Why is this so hard?

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/