[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <52374E4E.4060401@linaro.org>
Date: Mon, 16 Sep 2013 11:30:38 -0700
From: John Stultz <john.stultz@...aro.org>
To: elad.wexler@...il.com
CC: tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Time: Clocksource: fix 'ret' data type of sysfs_override_clocksource()
and sysfs_unbind_clocksource()
On 09/12/2013 03:28 AM, elad.wexler@...il.com wrote:
> From: Elad Wexler <elad.wexler@...il.com>
>
> sysfs_override_clocksource(): The expression 'if (ret >= 0)' is always true.
> This will cause clocksource_select() to always run.
> Thus modified ret to be of type ssize_t.
>
> sysfs_unbind_clocksource(): The expression 'if (ret < 0)' is always false.
> So in case sysfs_get_uname() failed, the expression won't take an effect.
> Thus modified ret to be of type ssize_t.
>
> Signed-off-by: Elad Wexler <elad.wexler@...il.com>
Queued for 3.13.
thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists