linux-kernel - Re: [PATCH] adjust the error labels to make it clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Sep 2013 04:13:41 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	baisong zhong <baisong.zhong@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]    adjust the error labels to make it clear

On Tue, Sep 17, 2013 at 05:15:13PM +0800, baisong zhong wrote:
> From: zhongbaisong <baisong.zhong@...il.com>
> 
> Signed-off-by: zhongbaisong <baisong.zhong@...il.com>

I need a changelog description in here, as to why you are making this
change, your Subject: is not descriptive at all.  What is being made
"clear"?

> ---
>  fs/sysfs/mount.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
> index afd8327..f6681a6 100644
> --- a/fs/sysfs/mount.c
> +++ b/fs/sysfs/mount.c
> @@ -182,12 +182,12 @@ int __init sysfs_init(void)
>  		}
>  	} else
>  		goto out_err;
> -out:
> -	return err;
> +
>  out_err:
>  	kmem_cache_destroy(sysfs_dir_cachep);
>  	sysfs_dir_cachep = NULL;
> -	goto out;
> +out:
> +	return err;

You tested this patch right?  Are you sure?  Really really sure?

greg "I don't think you tested this" k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/