linux-kernel - Re: [PATCH 4/6] USB: gadget: s3c-hsotg: fix "protocol stall" handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130917155754.GO15645@radagast>
Date:	Tue, 17 Sep 2013 10:57:54 -0500
From:	Felipe Balbi <balbi@...com>
To:	Robert Baldyga <r.baldyga@...sung.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<b.zolnierkie@...sung.com>, <m.szyprowski@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH 4/6] USB: gadget: s3c-hsotg: fix "protocol stall" handling

On Thu, Sep 12, 2013 at 04:18:50PM +0200, Robert Baldyga wrote:
> After normal handling of SetupDone interrupt, XferCompl interrupt occurs, and
> then we enqueue new setup request. But when ep0 is stalled, there is no
> XferCompl, so we have to enqueue setup request immediately after stalling ep.
> Otherwise incoming control requests won't be processed correctly.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
>  drivers/usb/gadget/s3c-hsotg.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index dd5524c..c581cd7 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -1146,6 +1146,8 @@ static int s3c_hsotg_process_req_feature(struct s3c_hsotg *hsotg,
>  	return 1;
>  }
>  
> +static void s3c_hsotg_enqueue_setup(struct s3c_hsotg *hsotg);
> +
>  /**
>   * s3c_hsotg_process_control - process a control request
>   * @hsotg: The device state
> @@ -1245,11 +1247,12 @@ static void s3c_hsotg_process_control(struct s3c_hsotg *hsotg,
>  		 * don't believe we need to anything more to get the EP
>  		 * to reply with a STALL packet
>  		 */
> +
> +		 /* complete won't by called, so we enqueue setup request here */

s/by/be

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)