linux-kernel - Re: [PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1379435727.2012.10.camel@joe-AO722>
Date:	Tue, 17 Sep 2013 09:35:27 -0700
From:	Joe Perches <joe@...ches.com>
To:	Iker Pedrosa <ikerpedrosam@...il.com>
Cc:	pavel@....cz, gregkh@...uxfoundation.org, harsh1kumar@...il.com,
	dan.carpenter@...cle.com, mujeeb.adil@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with
 netdev_err

On Mon, 2013-09-16 at 15:43 +0200, Iker Pedrosa wrote:
> The previously used printk lacked the warning level, now we've got a more accurate way to know the error.
[]
> diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
[]
> @@ -32,7 +32,7 @@ static void Wb35Tx_complete(struct urb *pUrb)
>  	struct wb35_tx *pWb35Tx = &pHwData->Wb35Tx;
>  	struct wb35_mds *pMds = &adapter->Mds;
>  
> -	printk("wb35: tx complete\n");
> +	netdev_err(pUrb->dev, "wb35: tx complete\n");

This one should either be removed or changed to netdev_dbg
with the "wb35: " prefix removed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/