linux-kernel - Re: [PATCH] clocksource: fix comment for __clocksource_updatefreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1309172056320.4089@ionos.tec.linutronix.de>
Date:	Tue, 17 Sep 2013 20:57:23 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Xie XiuQi <xiexiuqi@...wei.com>
cc:	John Stultz <john.stultz@...aro.org>, Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource: fix comment for
 __clocksource_updatefreq_scale

On Tue, 17 Sep 2013, Xie XiuQi wrote:

> The functions clocksource_updatefreq_hz() and clocksource_updatefreq_khz()
> do not exist, The proper ones are __clocksource_updatefreq_hz() and
> __clocksource_updatefreq_khz().

I'd rather rename the functions and the few call sites because the
underscores are completely meaningless.

Thanks,

	tglx

> Signed-off-by: Xie XiuQi <xiexiuqi@...wei.com>
> ---
>  kernel/time/clocksource.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 50a8736..d2f6ddc 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -714,7 +714,8 @@ static void clocksource_enqueue(struct clocksource *cs)
>   * This should only be called from the clocksource->enable() method.
>   *
>   * This *SHOULD NOT* be called directly! Please use the
> - * clocksource_updatefreq_hz() or clocksource_updatefreq_khz helper functions.
> + * __clocksource_updatefreq_hz() or __clocksource_updatefreq_khz helper
> + * functions.
>   */
>  void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
>  {
> -- 
> 1.8.2.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/