linux-kernel - Re: [PATCH] block: Device driver for sTec's PCIe Kronos Card.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOesGMhF42=qQLyMyF4-tsTjCxwX0bb10rTQv9sLooyzrEOpHA@mail.gmail.com>
Date:	Tue, 17 Sep 2013 12:04:18 -0700
From:	Olof Johansson <olof@...om.net>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Jeff Moyer <jmoyer@...hat.com>,
	OS Engineering <osengineering@...c-inc.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Akhil Bhansali <abhansali@...c-inc.com>,
	Ramprasad Chinthekindi <rchinthekindi@...c-inc.com>,
	Amit Phansalkar <aphansalkar@...c-inc.com>
Subject: Re: [PATCH] block: Device driver for sTec's PCIe Kronos Card.

On Thu, Sep 5, 2013 at 7:12 AM, Jens Axboe <axboe@...nel.dk> wrote:
> On 09/05/2013 06:00 AM, Jeff Moyer wrote:
>> OS Engineering <osengineering@...c-inc.com> writes:
>>
>>> Hi Jeff,
>>>
>>> Thank you for reviewing the patch.
>>
>> No problem.  Jens, any objection to queueing this up for 3.12?
>
> I'll give it a look-over, but usually I'm pretty lax when it comes to
> new drivers. So no, I'd be surprised if we can't queue this up for 3.12.

I came across this driver because it was spewing a lot of really
trivial and easy to fix compiler warnings. Silly stuff such as
printing u32 with %lu.

>From a quick look at the code, several things are immediately apparent:

First, checkpatch says, on the currently existing file in -next:

total: 3 errors, 61 warnings, 5817 lines checked

Code like this looks _really_ confused:

                barrier();
                val = readl(skdev->mem_map[1] + offset);
                barrier();

There are also some crazy long functions that should be refactored,
such as skd_request_fn().

So, it looks like this driver needs a bunch of work before it's ready
to go in. Or, maybe it's better to submit it with a TODO list for the
staging tree instead?


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/