linux-kernel - Re: Fix style in s3c-hsotg.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130918141106.GH21559@radagast>
Date:	Wed, 18 Sep 2013 09:11:06 -0500
From:	Felipe Balbi <balbi@...com>
To:	Pavel Machek <pavel@....cz>
CC:	Felipe Balbi <balbi@...com>,
	kernel list <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: Fix style in s3c-hsotg.c

Hi,

On Wed, Sep 18, 2013 at 11:20:27AM +0200, Pavel Machek wrote:
> On Tue 2013-09-17 20:45:39, Felipe Balbi wrote:
> > On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote:
> > > On Tue 2013-09-17 10:42:30, Felipe Balbi wrote:
> > > > Hi,
> > > > 
> > > > On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote:
> > > > > Hi!
> > > > > 
> > > > > checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> > > > > macro with if should be really enclosed in do {} while, and puts is
> > > > > going to be slightly faster.
> > > > > 
> > > > > Here's suggested patch. I don't have the hardware, so it is completely
> > > > > untested.
> > > > > 
> > > > > Signed-off-by: Pavel Machek, <pavel@...x.de>
> > > > 
> > > > this is not how you send a patch, please read
> > > > Documentation/SubmittingPatches
> > > 
> > > Have you considered possibility that this is how you nudge maintainer
> > > into fix their coding style?
> > 
> > cute...
> > 
> > Seriously though, read that file, you're commit log has garbage in it
> > which shouldn't go to git history.
> 
> Run git log on SubmittingPatches.
> 
> Then, instead of telling me what to read, run checkpatch on your
> files. You can either fix them yourself, or use my patch as a
> basis. Note there's missing } or something, so it probably will not
> compile, see the other mail. So you actually will have to modify that
> patch. Stripping "Hi!" from it should not be that hard, neither should
> be stripping note that patch is untested when you actually test
> it. And as you are the maintainer, it is your job.

you misunderstand the work of maintainers. Our work is not to fix you
crappy patches. If we start allowing crappy patches, we'd be fixing your
nonsense forever and linux wouldn't move.

> No, I'll not polish patch for hardware I don't have and have little
> interest in.  wanted to help you, but according to your first reply,
> you do not really want help.

that's your call. Now how about you stop being such a baby and go fix
your mistakes to start with ? Just because I'm the maintainer of the
gadget framework, doesn't mean I'm the maintainer of s3c-hsotc.c file.
Maintainer != author too, btw.

Anyway, I got much better stuff to do than babysitting grown ups.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)