linux-kernel - Re: [PATCH 05/11] cifs: fix filp leak in cifs_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mt8gnJs1ji==oF6wVv2hFXjCbbZ4quRY9Xum3Fx1UA_bw@mail.gmail.com>
Date:	Wed, 18 Sep 2013 10:19:20 -0500
From:	Steve French <smfrench@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, mszeredi@...e.cz,
	Steve French <sfrench@...ba.org>, stable@...r.kernel.org
Subject: Re: [PATCH 05/11] cifs: fix filp leak in cifs_atomic_open()

Do you want me to merge this via my tree (cifs-2.6.git) or another?

On Mon, Sep 16, 2013 at 7:51 AM, Miklos Szeredi <miklos@...redi.hu> wrote:
> From: Miklos Szeredi <mszeredi@...e.cz>
>
> If an error occurs after having called finish_open() then fput() needs to
> be called on the already opened file.
>
> Signed-off-by: Miklos Szeredi <mszeredi@...e.cz>
> Cc: Steve French <sfrench@...ba.org>
> Cc: stable@...r.kernel.org
> ---
>  fs/cifs/dir.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
> index d3e2eaa..5384c2a 100644
> --- a/fs/cifs/dir.c
> +++ b/fs/cifs/dir.c
> @@ -500,6 +500,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry,
>                 if (server->ops->close)
>                         server->ops->close(xid, tcon, &fid);
>                 cifs_del_pending_open(&open);
> +               fput(file);
>                 rc = -ENOMEM;
>         }
>
> --
> 1.8.1.4
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/