linux-kernel - Re: [PATCH 0/2] vsprintf: ignore %n again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130918152209.16302.qmail@science.horizon.com>
Date:	18 Sep 2013 11:22:09 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	dan.carpenter@...cle.com, penguin-kernel@...ove.SAKURA.ne.jp
Cc:	akpm@...ux-foundation.org, JBeulich@...e.com, joe@...ches.com,
	keescook@...omium.org, kosaki.motohiro@...il.com,
	linux-kernel@...r.kernel.org, linux@...izon.com,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH 0/2] vsprintf: ignore %n again

> +#define printk(fmt, ...) do {				  \
> +	compiletime_assert(__builtin_constant_p(fmt),     \
> +			   "Non-constant format string"); \
> +	printk(fmt, ##__VA_ARGS__);			  \
> +} while (0)

May I recommend __builtin_constant_p(*fmt).  Since:

char buf[OVERFLOW_VULNERABILITY];
strcpy(buf, malicious_format);
printk(buf, args)

has __builtin_constant_p(buf), but it's not a constant format string.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/