linux-kernel - Re: [PATCH 005/007] WAN Drivers: Update farsync driver and introduce fsflex driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1379519092.1522.27.camel@bwh-desktop.uk.level5networks.com>
Date:	Wed, 18 Sep 2013 16:44:52 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Kevin Curtis <Kevin.Curtis@...site.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"Dermot Smith" <dermot.smith@...site.com>
Subject: Re: [PATCH 005/007] WAN Drivers: Update farsync driver and
 introduce fsflex driver

On Wed, 2013-09-18 at 11:12 +0100, Kevin Curtis wrote:
> Farsite Communications FarSync driver update
> 
> Patch 5 of 7
> Note that this patch must be applied with patch 4 (farsync_include_patch)
> 
> Update the current farsync driver to support all of the PCI and PCI X
> cards manufactured by Farsite Communications.
> 
> Add a tty interface so that the ports can also be used by the ppp daemon.
> 
> Add support for big endian systems (the FarSite cards have a little endian
> processor on board).
[...]

Should all be separate patches.  This is just doing way too much in one
go.

And there are regressions in here like:

>  static struct pci_driver fst_driver = {
> -        .name          = FST_NAME,
> -        .id_table      = fst_pci_dev_id,
> -        .probe         = fst_add_one,
> -        .remove        = fst_remove_one,
> -        .suspend       = NULL,
> -        .resume        = NULL,
> +name: FST_NAME,
> +id_table : fst_pci_dev_id,
> +probe : fst_add_one,
> +remove : fst_remove_one,
> +suspend : NULL,
> +resume : NULL,
> +};

And the addition of a file in procfs (at the top level, even!) as if
it's still 2001 and sysfs doesn't exist:

> +static int farsync_proc_open(struct inode *inode, struct file *file)
> +{
> +       return single_open(file, fst_proc_info, NULL);
> +}
> +
> +static const struct file_operations farsync_proc_fops = {
> +       .open = farsync_proc_open,
> +       .read = seq_read,
> +       .llseek = seq_lseek,
> +       .release = single_release,
>  };

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/