linux-kernel - Re: [PATCHv3 02/16] drivers: thermal: introduce device tree parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1379534377.1787.59.camel@joe-AO722>
Date:	Wed, 18 Sep 2013 12:59:37 -0700
From:	Joe Perches <joe@...ches.com>
To:	Eduardo Valentin <eduardo.valentin@...com>
Cc:	swarren@...dotorg.org, pawel.moll@....com, mark.rutland@....com,
	ian.campbell@...rix.com, rob.herring@...xeda.com,
	linux@...ck-us.net, rui.zhang@...el.com, wni@...dia.com,
	grant.likely@...aro.org, durgadoss.r@...el.com,
	linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 02/16] drivers: thermal: introduce device tree parser

On Wed, 2013-09-18 at 15:44 -0400, Eduardo Valentin wrote:
> Hello Joe,

Hello Eduardo.

>  18-09-2013 15:11, Joe Perches wrote:
> > On Wed, 2013-09-18 at 15:02 -0400, Eduardo Valentin wrote:
> >> This patch introduces a device tree bindings for
> >> describing the hardware thermal behavior and limits.
> >> Also a parser to read and interpret the data and feed
> >> it in the thermal framework is presented.
> > 
> > trivial notes:
[]
> > If readings are within some non zero noise level,
> > perhaps stable should be returned.
> 
> Yes, there should be some sort of threshold for temperature trend. But I
> am not sure this is the right place to implement this. This type of
> feature is in my TODO list, but I am planing to get it done within the
> core code of the thermal framework.

No worries, one day...  Just wanted to bring it to attention.

> >> +static struct __thermal_zone *
> >> +thermal_of_build_thermal_zone(struct device_node *np)
> >> +{
[]
> >> +	tz = kzalloc(sizeof(*tz), GFP_KERNEL);
> >> +	if (!tz) {
> >> +		pr_err("not enough memory for thermal of zone\n");
> > 
> > Unnecessary OOM message.
> > All allocs without GFP_NOWARN get a dump_stack()

[]

> Hmmm.. I am pretty sure you have a good point. But to me seams to be
> still a common practice to have drivers outputing error messages when
> allocation fails. A simple git grep -A 4 kzalloc for instance, shows
> that there are still quite a considerable amount of occurrences of such
> practice.

True though a considerable number have been removed.
I think these should all be deleted eventually and
there's no good reason to add more.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/