linux-kernel - Re: [PATCH v2 2/4] gcov: add support for gcc 4.7 gcov format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130918143127.8dbdf6bc5e9d076a87cb2582@linux-foundation.org>
Date:	Wed, 18 Sep 2013 14:31:27 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Frantisek Hrbata <fhrbata@...hat.com>,
	linux-kernel@...r.kernel.org, jstancek@...hat.com,
	keescook@...omium.org, peter.oberparleiter@...ibm.com,
	rusty@...tcorp.com.au, linux-arch@...r.kernel.org, arnd@...db.de,
	mgahagan@...hat.com, agospoda@...hat.com
Subject: Re: [PATCH v2 2/4] gcov: add support for gcc 4.7 gcov format

On Wed, 18 Sep 2013 14:27:05 -0700 Joe Perches <joe@...ches.com> wrote:

> On Wed, 2013-09-18 at 14:22 -0700, Andrew Morton wrote:
> > On Wed,  4 Sep 2013 16:42:54 +0200 Frantisek Hrbata <fhrbata@...hat.com> wrote:
> > > The gcov in-memory format changed in gcc 4.7. The biggest change, which
> > > requires this special implementation, is that gcov_info no longer contains
> > > array of counters for each counter type for all functions and gcov_fn_info is
> > > not used for mapping of function's counters to these arrays(offset). Now each
> > > gcov_fn_info contans it's counters, which makes things a little bit easier.
> > > 
> > > This is heavily based on the previous gcc_3_4.c implementation and patches
> > > provided by Peter Oberparleiter. Specially the buffer gcda implementation for
> > > iterator.
> > 
> > A couple of little tweaks:
> []
> > +++ a/kernel/gcov/gcc_4_7.c
> []
> > @@ -267,8 +266,8 @@ struct gcov_info *gcov_info_dup(struct g
> >  	if (!dup->filename)
> >  		goto err_free;
> >  
> > -	dup->functions = kzalloc(sizeof(struct gcov_fn_info *) *
> > -			info->n_functions, GFP_KERNEL);
> > +	dup->functions = kcalloc(sizeof(struct gcov_fn_info *),
> > +				 info->n_functions, GFP_KERNEL);
> 
> kcalloc(n, size_t, flags)
> 
> 	dup->functions = kcalloc(info->n_functions,
> 				 sizeof(struct gcov_fn_info *), GFP_KERNEL);
> 

Already did that after checkpatch whined at me.  Stupid thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/