linux-kernel - Re: [PATCH v3 3/6] uas: make work list per-device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1379489584.12907.11.camel@nilsson.home.kraxel.org>
Date:	Wed, 18 Sep 2013 09:33:04 +0200
From:	Gerd Hoffmann <kraxel@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-usb@...r.kernel.org, Matthew Wilcox <willy@...ux.intel.com>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:USB ATTACHED SCSI" <linux-scsi@...r.kernel.org>,
	"open list:USB MASS STORAGE..." 
	<usb-storage@...ts.one-eyed-alien.net>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/6] uas: make work list per-device

On Di, 2013-09-17 at 13:30 -0700, Christoph Hellwig wrote:
> On Fri, Sep 13, 2013 at 01:27:12PM +0200, Gerd Hoffmann wrote:
> > Simplifies locking, we'll protect the list with the device spin lock.
> > Also plugs races which can happen when two devices operate on the
> > global list.
> > 
> > While being at it rename the list head from "list" to "work", preparing
> > for the addition of a second list.
> 
> Why do you even the list?

The list was already there when I took over maintainance ...

> What would a ordered per-device workqueue not
> provide?

Had no reason to look into replacing the list with something else so
far.  Why do you suggest using a workqueue instead?

Note that the list is not used in a typical request workflow.  Only in
case queuing an usb urb failed the request is linked into the list and
the worker will try to submit the usb urb again.

cheers,
  Gerd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/