| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Sep 2013 10:20:14 +0200
From: Pali Rohár <pali.rohar@...il.com>
To: balbi@...com, Tony Lindgren <tony@...mide.com>,
Anton Vorontsov <anton@...msg.org>,
Russell King <linux@....linux.org.uk>,
David Woodhouse <dwmw2@...radead.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
freemangordon@....bg, aaro.koskinen@....fi, pavel@....cz
Cc: linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/4] usb: musb: Call atomic_notifier_call_chain when status is changed
On Wednesday 18 September 2013 03:49:42 Felipe Balbi wrote:
> On Tue, Sep 17, 2013 at 09:28:42PM +0200, Pali Rohár wrote:
> > On Tuesday 17 September 2013 18:08:35 Felipe Balbi wrote:
> > > On Tue, Sep 17, 2013 at 06:05:15PM +0200, Pali Rohár wrote:
> > > > On Tuesday 17 September 2013 17:48:59 you wrote:
> > > > > On Sun, Sep 08, 2013 at 10:50:36AM +0200, Pali Rohár wrote:
> > > > > > More power supply drivers depends on vbus events and
> > > > > > without it they not working. Power supply drivers
> > > > > > using usb_register_notifier, so to deliver events
> > > > > > it is needed to call atomic_notifier_call_chain.
> > > > > >
> > > > > > So without atomic notifier power supply driver
> > > > > > isp1704 not retrieving vbus status and reporting
> > > > > > bogus values to userspace and also to board
> > > > > > platform data functions. Without proper data
> > > > > > charger drivers trying to charge battery also when
> > > > > > charger is disconnected or do not start charging
> > > > > > when wallcharger connects.
> > > > > >
> > > > > > Atomic notifier in musb driver was used before v3.5
> > > > > > and was replaced with omap mailbox. This patch
> > > > > > adding atomic_notifier_call_chain call from
> > > > > > function omap_musb_set_mailbox.
> > > > > >
> > > > > > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > > > > > ---
> > > > > >
> > > > > > drivers/usb/musb/omap2430.c | 3 +++
> > > > > > drivers/usb/phy/phy-twl4030-usb.c | 2 ++
> > > > > > 2 files changed, 5 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/usb/musb/omap2430.c
> > > > > > b/drivers/usb/musb/omap2430.c index f44e8b5..5c40252
> > > > > > 100644 --- a/drivers/usb/musb/omap2430.c
> > > > > > +++ b/drivers/usb/musb/omap2430.c
> > > > > > @@ -305,6 +305,9 @@ static void
> > > > > > omap_musb_set_mailbox(struct omap2430_glue *glue)
> > > > > >
> > > > > > default:
> > > > > > dev_dbg(dev, "ID float\n");
> > > > > >
> > > > > > }
> > > > > >
> > > > > > +
> > > > > > + atomic_notifier_call_chain(&musb->xceiv->notifier,
> > > > > > + musb->xceiv->last_event, NULL);
> > > > >
> > > > > let's add a wrapper for this:
> > > > >
> > > > > static inline int usb_phy_notify(struct usb phy *x,
> > > > > unsigned val, void *v) {
> > > > >
> > > > > return atomic_notifier_call_chain(&x->notifier, val,
> > > > > v);
> > > > >
> > > > > }
> > > >
> > > > Where to add this wrapper? To omap2430.c? or some
> > > > include file?
> > >
> > > <linux/usb/phy.h>
> > >
> > > > On Tuesday 17 September 2013 17:49:17 Felipe Balbi wrote:
> > > > > On Sun, Sep 08, 2013 at 10:50:36AM +0200, Pali Rohár wrote:
> > > > > > diff --git a/drivers/usb/phy/phy-twl4030-usb.c
> > > > > > b/drivers/usb/phy/phy-twl4030-usb.c index
> > > > > > 8f78d2d..efe6155 100644
> > > > > > --- a/drivers/usb/phy/phy-twl4030-usb.c
> > > > > > +++ b/drivers/usb/phy/phy-twl4030-usb.c
> > > > > > @@ -705,6 +705,8 @@ static int
> > > > > > twl4030_usb_probe(struct platform_device *pdev)
> > > > > >
> > > > > > if (device_create_file(&pdev->dev,
> > > > > > &dev_attr_vbus))
> > > > > >
> > > > > > dev_warn(&pdev->dev, "could not create sysfs
> > > > > > file\n");
> > > > > >
> > > > > > + ATOMIC_INIT_NOTIFIER_HEAD(&twl->phy.notifier);
> > > > >
> > > > > BTW, this is a bugfix, send separately.
> > > >
> > > > What to send separately?
> > > >
> > > > This full patch 1/4 is bugfix. And I did not understand
> > > > what you want. Maybe it could be easier for you to
> > > > apply this small 3+2 lines patch how you need.
> > >
> > > This hunk here (initializaing notifier head) is a separate
> > > bug fix and needs its own patch.
> >
> > So will you do that? Or it is needed to resend this one line
> > hunk again in new email again?
>
> new patch, new email
Guys, WHY ARE YOU SO STUPID AND ARROGANT?
Sorry but, need to copy full isolated patch/hunk from one mail to
another is hassling. So what you want from me? Do all those non
sense working only because yesterday you had bad day? Or what?
Everything needed with described information was in first mail.
Also second hunk has full isolated "git diff" output, so it is for
you really big problem to copy it? Or you did not see that patch?
I really did not understand what you wanted from me.
============================
==== BEGINNING OF PATCH ====
============================
This is bugfix and sending this patch separately from all other patches.
This patch is visibly isolated from all others and could be readable also
by disabled people. For other handicapped people I suggest to increase
font size and other text settings in program which view this patch.
For visually impaired people I suggest to use some text-to-speech software.
This is small 2 lines patch, diff starting after next visible break.
This patch initializing notifier head in tw4030 usb code which is missing.
Initialization code is needed for using any atomic_notifier_* functions.
Signed-off-by: Pali Rohár <pali.rohar@...il.com>
===========================
==== BEGINNING OF DIFF ====
===========================
diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c
index 8f78d2d..efe6155 100644
--- a/drivers/usb/phy/phy-twl4030-usb.c
+++ b/drivers/usb/phy/phy-twl4030-usb.c
@@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct platform_device *pdev)
if (device_create_file(&pdev->dev, &dev_attr_vbus))
dev_warn(&pdev->dev, "could not create sysfs file\n");
+ ATOMIC_INIT_NOTIFIER_HEAD(&twl->phy.notifier);
+
/* Our job is to use irqs and status from the power module
* to keep the transceiver disabled when nothing's connected.
*
======================
==== END OF PATCH ====
======================
PS: This is end of email and patch is above ^^^^
--
Pali Rohár
pali.rohar@...il.com
Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)
Powered by blists - more mailing lists