linux-kernel - Re: [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPI I/O function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Sep 2013 10:56:28 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Marc Reilly <marc@...esign.com.au>,
	u.kleine-koenig@...gutronix.de, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, linaro-kernel@...ts.linaro.org
Subject: Re: [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPI
 I/O function

On Thu, Sep 19, 2013 at 10:13:18AM +0100, Lee Jones wrote:

Please delete irrelevant context from mails, it makes it easier to find
the new content that's beenn added.

> On Wed, 18 Sep 2013, Mark Brown wrote:

> > @@ -94,10 +94,15 @@ static int mc13xxx_spi_write(void *context, const void *data, size_t count)
> >  {
> >  	struct device *dev = context;
> >  	struct spi_device *spi = to_spi_device(dev);
> > +	char *reg = data;

> I think this requires a cast.

No, you should never need a cast to or from void in C - it probably does
want to be a const char though.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)