linux-kernel - Re: [PATCH] staging: usbip: Fix build on Debian ppc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130919101041.GA9196@d-paulus.de>
Date:	Thu, 19 Sep 2013 12:10:41 +0200
From:	Dominik Paulus <dominik@...aulus.de>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Tobias Polzer <bulsa.t.polzer@...dium.uni-erlangen.de>,
	usbip-devel@...ts.sourceforge.net,
	Dominik Paulus <dominik.paulus@....de>,
	Anthony Foiani <anthony.foiani@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...cs.fau.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, Tobias Polzer <tobias.polzer@....de>,
	linux-kernel@...r.kernel.org, Stefan Reif <ke42caxa@....cs.fau.de>
Subject: Re: [PATCH] staging: usbip: Fix build on Debian ppc

On Thu, Sep 19, 2013 at 12:12:44PM +0300, Dan Carpenter wrote:
> On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote:
> > When testing usbip under powerpc, it (unexpectedly) worked, but only after
> > removing the following lines from vhch_hcd.c:
> > 
> > 1004         /* will be removed */
> > 1005         if (pdev->dev.dma_mask) {
> > 1006                 dev_info(&pdev->dev, "vhci_hcd DMA not supported\n");
> > 1007                 return -EINVAL;
> > 1008         }
> > 
> > We encountered no problems without those lines. Is it safe to remove this
> > check?
> 
> Hehe.  No.
> 
> Also which vhch_hcd.c are you talking about?  "find -name vhch_hcd.c"
> doesn't show anything.

Sorry for the typo, we meant vhci_hcd.c in
drivers/staging/usbip/vhci_hcd.c.

> What the error message?

When modprobing vhci_hcd.ko, vhci_hcd_probe() fails and returns -EINVAL,
resulting in this error message:

[  592.623292] vhci_hcd vhci_hcd: vhci_hcd DMA not supported
[  592.624031] vhci_hcd: probe of vhci_hcd failed with error -22

This leads to the virtual host controller device (vhci) not being
created, so usbip cannot work.
It works after removing the codeblock mentioned above.

We did some research and discovered that dma_mask is only set on PowerPC
at the moment (in arch/powerpc/kernel/setup-common.c,
arch_setup_pdev_archdata()).

All of our testing was done in QEMU emulating Debian on POWER7.

Regards,
	Tobias Polzer and Dominik Paulus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/