lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <523ADDDC.7010008@gmail.com>
Date:	Thu, 19 Sep 2013 13:19:56 +0200
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Quentin Armitage <quentin@...itage.org.uk>,
	linux-kernel@...r.kernel.org
CC:	Jason Cooper <jason@...edaemon.net>
Subject: Re: [PATCH 1/1] Fix address of second XOR engine in Kirkwood SoC
 DT

On 09/19/13 13:00, Quentin Armitage wrote:
> There appears to be an error in the second address of the second XOR
> engine in the Kirkwood SoC device tree, which is specified as 0xd0b00
> but should be 0x60b00.
>
> For confirmation of address see
> http://www.marvell.com/embedded-processors/kirkwood/assets/FS_88F6180_9x_6281_OpenSource.pdf table 581 page 658.
> Also see definition of XOR1_HIGH_PHYS_BASE in
> arch/arm/mach-kirkwood/include/mach/kirkwood.h
> #define XOR1_HIGH_PHYS_BASE    (KIRKWOOD_REGS_PHYS_BASE + 0x60B00)
>
> Signed-off-by: Quentin Armitage <quentin@...itage.org.uk>

I double-checked the references, typo and fix are correct.

Reviewed-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>

> ---
>   arch/arm/boot/dts/kirkwood.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood.dtsi
> b/arch/arm/boot/dts/kirkwood.dtsi
> index cf7aeaf..63d4066 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -167,7 +167,7 @@
>   		xor@...00 {
>   			compatible = "marvell,orion-xor";
>   			reg = <0x60900 0x100
> -			       0xd0B00 0x100>;
> +			       0x60B00 0x100>;
>   			status = "okay";
>   			clocks = <&gate_clk 16>;
>
> ---
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ