linux-kernel - Re: [PATCH] ASoC: rt5640: Omit ACPI match table only if !ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130919132234.GQ21013@sirena.org.uk>
Date:	Thu, 19 Sep 2013 14:22:34 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rt5640: Omit ACPI match table only if !ACPI

On Thu, Sep 19, 2013 at 01:21:04PM +0200, Thierry Reding wrote:

> Or perhaps we can annotate the table so that the compiler will stop
> complaining but remove the table nonetheless if it isn't used. Similarly
> to what we can do with
> 
> 	if (IS_ENABLED(CONFIG_FOO)) {
> 		...
> 	}
> 
> constructs. I can't really think of a way to do that, though. Perhaps
> gcc will throw away the table anyway, so we'll just need a way to make
> it shut up?

There's an annotation which can stop the unreferenced variable warning
and then modern compilers are able to eliminate unreferenced static
symbols.  Not sure if it's actually worth the effort of doing all this
though, but it is nice to be able to avoid needing multiple builds.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)