linux-kernel - Re: [3.12-rc1 regression] [BISECTED] X fails to start on Latitude E6510 w/ NOUVEAU DRM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <21051.6912.160446.508756@pilspetsen.it.uu.se>
Date:	Thu, 19 Sep 2013 17:40:48 +0200
From:	Mikael Pettersson <mikpe@...uu.se>
To:	Mikael Pettersson <mikpe@...uu.se>
Cc:	linux-kernel@...r.kernel.org,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Dave Airlie <airlied@...hat.com>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [3.12-rc1 regression] [BISECTED] X fails to start on Latitude E6510 w/ NOUVEAU DRM driver

I wrote:
 > Dell Latitude E6510, CONFIG_DRM_NOUVEAU, 64-bit Fedora 17 user-space, Xorg drivers, and
 > 
 > 01:00.0 VGA compatible controller: nVidia Corporation GT218 [NVS 3100M] (rev a2).
 > 
 > With 3.11 X starts fine, with 3.12-rc1 it fails with the following in Xorg.0.log:
 > 
 > ...
 > [    56.819] (II) Loading /usr/lib64/xorg/modules/drivers/nouveau_drv.so
 > [    56.842] (II) Module nouveau: vendor="X.Org Foundation"
 > [    56.842]    compiled for 1.12.2, module version = 0.0.16
 > [    56.842]    Module class: X.Org Video Driver
 > [    56.842]    ABI class: X.Org Video Driver, version 12.0
 > [    56.842] (II) NOUVEAU driver 
 > [    56.842] (II) NOUVEAU driver for NVIDIA chipset families :
 > [    56.842]    RIVA TNT        (NV04)
 > [    56.842]    RIVA TNT2       (NV05)
 > [    56.842]    GeForce 256     (NV10)
 > [    56.842]    GeForce 2       (NV11, NV15)
 > [    56.842]    GeForce 4MX     (NV17, NV18)
 > [    56.842]    GeForce 3       (NV20)
 > [    56.842]    GeForce 4Ti     (NV25, NV28)
 > [    56.842]    GeForce FX      (NV3x)
 > [    56.842]    GeForce 6       (NV4x)
 > [    56.842]    GeForce 7       (G7x)
 > [    56.842]    GeForce 8       (G8x)
 > [    56.842]    GeForce GTX 200 (NVA0)
 > [    56.842]    GeForce GTX 400 (NVC0)
 > [    56.842] (--) using VT number 7
 > 
 > [    56.845] drmOpenDevice: node name is /dev/dri/card0
 > [    56.845] drmOpenDevice: open result is 9, (OK)
 > [    56.845] drmOpenByBusid: Searching for BusID pci:0000:01:00.0
 > [    56.845] drmOpenDevice: node name is /dev/dri/card0
 > [    56.845] drmOpenDevice: open result is 9, (OK)
 > [    56.845] drmOpenByBusid: drmOpenMinor returns 9
 > [    56.845] drmOpenByBusid: drmGetBusid reports pci:0000:01:00.0
 > [    56.845] (EE) [drm] failed to open device
 > [    56.845] (EE) No devices detected.
 > 
 > With 3.11 one instead sees:
 > 
 > ...
 > [    33.879] drmOpenByBusid: drmOpenMinor returns 9
 > [    33.879] drmOpenByBusid: drmGetBusid reports pci:0000:01:00.0
 > [    33.879] (II) [drm] nouveau interface version: 1.1.1
 > [    33.879] (II) Loading sub module "dri"
 > ...
 > 
 > There are no messages in the kernel's log that indicate any problem.
 > 
 > stracing xinit shows:
 > 
 > 964   open("/dev/dri/card0", O_RDWR)    = 9
 > 964   write(0, "[  1120.365] ", 13)     = 13
 > 964   write(0, "drmOpenDevice: open result is 9,"..., 38) = 38
 > 964   write(0, "[  1120.365] ", 13)     = 13
 > 964   write(0, "drmOpenByBusid: drmOpenMinor ret"..., 39) = 39
 > 964   ioctl(9, 0xc0106407, 0x7fffda0d4800) = 0
 > 964   ioctl(9, 0xc0106401, 0x7fffda0d4800) = 0
 > 964   ioctl(9, 0xc0106401, 0x7fffda0d4800) = 0
 > 964   write(0, "[  1120.365] ", 13)     = 13
 > 964   write(0, "drmOpenByBusid: drmGetBusid repo"..., 53) = 53
 > 964   ioctl(9, 0xc0086420, 0x7fffda0d4870) = -1 EINVAL (Invalid argument)
 > 964   fstat(9, {st_dev=makedev(0, 5), st_ino=2348, st_mode=S_IFCHR|0660, st_nlink=1, st_uid=0, st_gid=39, st_blksize=4096, st_blocks=0, st_rdev=makedev(226, 0), st_atime=2013/09/17-11:25:35, st_mtime=2013/09/17-11:25:35, st_ctime=2013/09/17-11:43:58}) = 0
 > 964   fstat(9, {st_dev=makedev(0, 5), st_ino=2348, st_mode=S_IFCHR|0660, st_nlink=1, st_uid=0, st_gid=39, st_blksize=4096, st_blocks=0, st_rdev=makedev(226, 0), st_atime=2013/09/17-11:25:35, st_mtime=2013/09/17-11:25:35, st_ctime=2013/09/17-11:43:58}) = 0
 > 964   close(9)                          = 0
 > 964   write(0, "[  1120.366] ", 13)     = 13
 > 964   write(0, "(EE) [drm] failed to open device"..., 33) = 33
 > 
 > So it looks like that ioctl 0xc0086420 is the culprit.
 > 
 > Any ideas?  I may have time to try a bisection tomorrow.

The bisection identified:

>>From 7c510133d93dd6f15ca040733ba7b2891ed61fd1 Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@...ll.ch>
>Date: Thu, 08 Aug 2013 13:41:21 +0000
>Subject: drm: mark context support as a legacy subsystem
>
>So after a lot of digging around in git histories it looks like this
>has only ever be used by dri1 render clients. Hence we can fully
>disable the entire thing for modesetting drivers and so greatly reduce
>the attack surface for potential exploits (or at least tools like
>trinity ...).
>
>Also add the drm_legacy prefix for functions which are called from
>common code. To further reduce the impact on common code also extract
>all the ctx release handling into a function (instead of only
>releasing individual handles) and make ctxbitmap_cleanup return void -
>it can never fail.
>
>Reviewed-by: Eric Anholt <eric@...olt.net>
>Signed-off-by: Daniel Vetter <daniel.vetter@...ll.ch>
>Signed-off-by: Dave Airlie <airlied@...hat.com>

as the culprit.  Reverting it from 3.12-rc1 allows X to start on this machine.

The issue seems driver dependent, as another Fedora 17 machine of mine
with Radeon graphics works fine with vanilla 3.12-rc1.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/