linux-kernel - Re: [PATCH] RX-51: Add missing max_current to rx51_lp5523_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Sep 2013 14:29:22 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Russell King <linux@....linux.org.uk>, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RX-51: Add missing max_current to
 rx51_lp5523_led_config

* Pali Rohár <pali.rohar@...il.com> [130919 14:10]:
> On Thursday 19 September 2013 00:26:43 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@...il.com> [130918 15:02]:
> > > Without max_current data in board file lp5523 driver does
> > > not change current.
> > 
> > Hmm is this a regression or are there other reasons to merge
> > this during the -rc cycle?
> > 
> 
> I think this is regression, drivers/leds/leds-lp55xx-common.c 
> code refuse to change led_current sysfs attribute if value is 
> higher than max_current specified in board file. And because in 
> board file max_current is not specified it is by default zero as 
> global variable. So changing led_current is not possible because 
> any positive value is more than zero. First I saw this behaviour 
> in 3.10, but I forgot to send this patch.

OK thanks, can you please update the patch description with
that so I can merge it for the -rc cycle? Ideally of course
with the breaking commit too.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/