linux-kernel - Re: [PATCH] mfd: core: introduce of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523ABC85.5030607@nvidia.com>
Date:	Thu, 19 Sep 2013 14:27:41 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"rob@...dley.net" <rob@...dley.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [PATCH] mfd: core: introduce of_node_name for mfd sub devices

On Thursday 19 September 2013 02:00 PM, Lee Jones wrote:
> On Thu, 19 Sep 2013, Laxman Dewangan wrote:
>
>> Multi Function Devices (MFDs) have multiple sub module whose driver is
>> developed in different sub-system like GPIO, regulators, RTC, clock etc.
>> The device tree of such device contains multiple sub-node which contains
>> the properties of these sub-modules.
>>
>> The sub module gets of_node handle either by the dev->of_node or by getting
>> the child node handle from parent DT handle by finding child name on parent's
>> of_node.
>>
>> To provide the of_node of sub-module directly, currently there is only one
>> approach:
>> - Add compatible value when defining the sub-module in mfd core and
>>    add this properties when adding DT.
>>
>> Introduce the of_node_name of each sub devices which is set when defining
>> the mfd_cells of the sub devices and get the handle of these child node
>> when adding the mfd_devices by getting the sub-node handle with matching
>> the node name getting the sub-node handle with matching the node name.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
>> ---
>> Creating this patch based on the discussion on patch
>> [PATCH 1/4] mfd: add support for AMS AS3722 PMIC
>> The discussion on above patch is not concluded and want to have
>> further discussion on this patch.
> I'm not entirely sure this is what Mark was saying. I think he was
> complaining about the existence of the sub-nodes rather than how the
> MFD Core assigns their of_node.

Yes, Mark is only saying that he is not comfortable with the compatible 
until it is ip based driver.
I wanted to continue the discussion to find out the acceptable way so 
that I can use this in as3722 driver.

I added the of_node_name because each sub-driver gets its sub node by 
finding child node name from parent and hence duplicated the code on 
each driver.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/