linux-kernel - Re: nouveau: remove pointless assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1045388466.15024620.1379553015692.JavaMail.root@redhat.com>
Date:	Wed, 18 Sep 2013 21:10:15 -0400 (EDT)
From:	Ben Skeggs <bskeggs@...hat.com>
To:	Dave Jones <davej@...hat.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, airlied@...hat.com
Subject: Re: nouveau: remove pointless assignment

----- Original Message -----
> From: "Dave Jones" <davej@...hat.com>
> To: "Linux Kernel" <linux-kernel@...r.kernel.org>
> Cc: bskeggs@...hat.com, airlied@...hat.com
> Sent: Wednesday, 18 September, 2013 7:26:34 AM
> Subject: nouveau: remove pointless assignment
> 
> self-assignment of a variable doesn't make a lot of sense.
Thanks, search-and-replace left-over, pulled into my tree.

Ben.

> 
> Signed-off-by: Dave Jones <davej@...oraproject.org>
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c
> b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 755c38d..d0a737c 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -982,7 +982,7 @@ nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int
> evict, bool intr,
>  		     bool no_wait_gpu, struct ttm_mem_reg *new_mem)
>  {
>  	struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> -	struct nouveau_channel *chan = chan = drm->ttm.chan;
> +	struct nouveau_channel *chan = drm->ttm.chan;
>  	struct nouveau_bo *nvbo = nouveau_bo(bo);
>  	struct ttm_mem_reg *old_mem = &bo->mem;
>  	int ret;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/