linux-kernel - [PATCH v3 0/7] usb: s3c-hsotg: fixes for proper functioning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Sep 2013 11:50:16 +0200
From:	Robert Baldyga <r.baldyga@...sung.com>
To:	balbi@...com
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, b.zolnierkie@...sung.com,
	m.szyprowski@...sung.com, Robert Baldyga <r.baldyga@...sung.com>
Subject: [PATCH v3 0/7] usb: s3c-hsotg: fixes for proper functioning

Hello,

This is a third version of set of patches fixing s3c-hsotg USB driver
functioning. From the previous vesrion there are two changes - fixed
one small mistake found in one of patches, and add new patch fixing
interrupt configuration for dedicated-fifo mode.

These patches add few fixes:
- Fix "protocol stall" handling, by enqueue new ep0 request when stalled
- Fix s3c_hsotg_write_fifo function to be usable in dedicated-fifo mode.
  Actually PTxFEmp/NPTxFEmp interrupts are enabled only in shared-fifo mode.
- Fix endpoint interrput handling, by disabling interrupts for endpoints which
  has no requests enqueued.
- Fixed DAINT register usage. Now only masked ep interrupts are handled.
- Fix "halt" property updating.
- Fix endpoint halt clearing, when it is not currently halted.
- Fix interrupt configuration in dedicated fifo mode.

Best regards
Robert Baldyga
Samsung R&D Institute Poland

Changelog:

v3:
- in patch 'fix clear feature ENDPOINT_HALT' fixed mistake in that logic OR
  were used instead of logic AND
- add patch setting correct interrupt configuration for dedicated-fifo mode

v2: https://lkml.org/lkml/2013/9/18/99
- splitted patches to get one fix in each patch, as Felipe Balbi suggested
- fixed typos

v1: https://lkml.org/lkml/2013/9/12/324
- initial proposal

Robert Baldyga (7):
  USB: gadget: s3c-hsotg: fix "protocol stall" handling
  USB: gadget: s3c-hsotg: fix s3c_hsotg_write_fifo function for
    dedicated fifo mode
  USB: gadget: s3c-hsotg: fix endpoint interrupts handling
  USB: gadget: s3c-hsotg: add DAINT masking
  USB: gadget: s3c-hsotg: fix "halted" property updating
  USB: gadget: s3c-hsotg: fix clear feature ENDPOINT_HALT
  USB: gadget: s3c-hsotg: fix interrupt configuration in dedicated-fifo
    mode

 drivers/usb/gadget/s3c-hsotg.c |   74 +++++++++++++++++++++++++++++++---------
 1 file changed, 57 insertions(+), 17 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/