linux-kernel - Re: [PATCH] audit: remove newline accidentally added during session id helper refactor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Sep 2013 12:08:46 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Richard Guy Briggs <rgb@...hat.com>
Cc:	linux-audit@...hat.com, linux-kernel@...r.kernel.org,
	Steve Grubb <sgrubb@...hat.com>
Subject: Re: [PATCH] audit: remove newline accidentally added during session
 id helper refactor

On Wed, 2013-09-18 at 11:17 -0400, Richard Guy Briggs wrote:
> A newline was accidentally added during session ID helper refactorization in
> commit 4d3fb709.  This needlessly uses up buffer space, messes up syslog
> formatting and makes userspace processing less efficient.  Remove it.
> 
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>

Acked-by: Eric Paris <eparis@...hat.com>

> ---
>  kernel/audit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 3d17670..ac16540 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -1413,7 +1413,7 @@ void audit_log_session_info(struct audit_buffer *ab)
>  	u32 sessionid = audit_get_sessionid(current);
>  	uid_t auid = from_kuid(&init_user_ns, audit_get_loginuid(current));
>  
> -	audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid);
> +	audit_log_format(ab, " auid=%u ses=%u", auid, sessionid);
>  }
>  
>  void audit_log_key(struct audit_buffer *ab, char *key)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/