linux-kernel - tracing: don't stuff stale pointers in filp->private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130920164732.GA31520@redhat.com>
Date:	Fri, 20 Sep 2013 12:47:32 -0400
From:	Dave Jones <davej@...hat.com>
To:	rostedt@...dmis.org
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: tracing: don't stuff stale pointers in filp->private_data

Probably harmless, but still not a nice thing to do.

Signed-off-by: Dave Jones <davej@...oraproject.org>

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 368a4d5..75d3556 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode, struct file *filp)
 	if (ret < 0) {
 		trace_array_put(tr);
 		kfree(dir);
+		dir = NULL;
 	}
 
 	filp->private_data = dir;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/