linux-kernel - Re: [PATCH] Input: atmel_tscadcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130920170135.GB6300@core.coreip.homeip.net>
Date:	Fri, 20 Sep 2013 10:01:35 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Manish Badarkhe <badarkhe.manish@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	josh.wu@...el.com
Subject: Re: [PATCH] Input: atmel_tscadcc - update to devm_* API

Hi Manish,

On Mon, Sep 16, 2013 at 08:22:58PM +0530, Manish Badarkhe wrote:
>  static int atmel_tsadcc_remove(struct platform_device *pdev)
>  {
>  	struct atmel_tsadcc *ts_dev = platform_get_drvdata(pdev);
> -	struct resource *res;
> -
> -	free_irq(ts_dev->irq, ts_dev);
>  
>  	input_unregister_device(ts_dev->input);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	iounmap(tsc_base);
> -	release_mem_region(res->start, resource_size(res));
> -
>  	clk_disable(ts_dev->clk);
> -	clk_put(ts_dev->clk);
> -
> -	kfree(ts_dev);
>  
>  	return 0;
>  }


By doing this conversion we disable the clock too early. I need to
resurrect my patches to add devm_clk_enable and then we can revisit this
patch.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/