linux-kernel - Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523C95B0.6070906@kernel.org>
Date:	Fri, 20 Sep 2013 19:36:32 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
CC:	Thomas Meyer <thomas@...3r.de>, jic23@....ac.uk,
	grant.likely@...aro.org, rob.herring@...xeda.com,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"

On 09/20/13 08:26, Nicolas Ferre wrote:
> On 19/09/2013 23:42, Thomas Meyer :
>> sizeof when applied to a pointer typed expression gives the size of the
>> pointer.
>> Found by coccinelle spatch "misc/noderef.cocci"
>>
>> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
Applied to the fixes-togreg branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Thanks,
> 
>> ---
>>
>> diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
>> --- a/drivers/iio/adc/at91_adc.c
>> +++ b/drivers/iio/adc/at91_adc.c
>> @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct
>>       int i, ret;
>>
>>       st->trig = devm_kzalloc(&idev->dev,
>> -                st->trigger_number * sizeof(st->trig),
>> +                st->trigger_number * sizeof(*st->trig),
>>                   GFP_KERNEL);
>>
>>       if (st->trig == NULL) {
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/