linux-kernel - Re: [PATCH 5/6] clk: exynos-audss: add support for Exynos 5420

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1407151.hAbz8S9ABE@flatron>
Date:	Sat, 21 Sep 2013 17:17:28 +0200
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Andrew Bresticker <abrestic@...omium.org>,
	linux-samsung-soc@...r.kernel.org,
	Mark Rutland <mark.rutland@....com>,
	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	linux-doc@...r.kernel.org, Tomasz Figa <t.figa@...sung.com>,
	linux-kernel@...r.kernel.org,
	Tushar Behera <tushar.behera@...aro.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Grant Likely <grant.likely@...aro.org>,
	devicetree@...r.kernel.org, Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <rob.herring@...xeda.com>,
	Mike Turquette <mturquette@...aro.org>,
	Rahul Sharma <rahul.sharma@...sung.com>,
	Padmavathi Venna <padma.v@...sung.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Doug Anderson <dianders@...omium.org>,
	Leela Krishna Amudala <l.krishna@...sung.com>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH 5/6] clk: exynos-audss: add support for Exynos 5420

Hi Andrew,

On Friday 20 of September 2013 14:13:56 Andrew Bresticker wrote:
> The AudioSS block on Exynos 5420 has an additional clock gate for the
> ADMA bus clock.
> 
> Signed-off-by: Andrew Bresticker <abrestic@...omium.org>
> ---
>  Documentation/devicetree/bindings/clock/clk-exynos-audss.txt | 7
> +++++-- drivers/clk/samsung/clk-exynos-audss.c                       |
> 8 ++++++++ include/dt-bindings/clk/exynos-audss-clk.h                  
> | 3 ++- 3 files changed, 15 insertions(+), 3 deletions(-)
[snip]
> +	if (of_device_is_compatible(pdev->dev.of_node,
> +					"samsung,exynos5420-audss-clock")) 
{

I don't really like using such string based conditions in the code, but I 
guess it's just a matter of preference.

I'd introduce an enum to represent supported variants and put them into 
the OF match table or maybe even a struct that would have a bool named 
has_adma_clock, true for Exynos5420 variant.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/