linux-kernel - Re: [PATCH 1/3] iio: ti_am335x_adc: fix static in function header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523F3109.8000600@kernel.org>
Date:	Sun, 22 Sep 2013 19:03:53 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Zubair Lutfullah <zubair.lutfullah@...il.com>
CC:	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/3] iio: ti_am335x_adc: fix static in function header

On 09/22/13 09:20, Zubair Lutfullah wrote:
> Static is missing in function header. Corrected.
> 
> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@...il.com>
Applied to the togreg branch of iio.git

As you've probably gathered, a run of sparse on your code before posting is a
great way to pick up on little things like this.  Also, coccinelle and
smatch if you want to do a thorough job - each gets a slightly different
set of common bugs.  I tend to run some combination of those, but wasn't
set up to build this driver so didn't pick up on this.

Another one clocked up to the autobuilders.  Note it is normal to give
a reported-by line to give them some credit. I've added one.

Jonathan
> ---
>  drivers/iio/adc/ti_am335x_adc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
> index 5287bff..91dce1f 100644
> --- a/drivers/iio/adc/ti_am335x_adc.c
> +++ b/drivers/iio/adc/ti_am335x_adc.c
> @@ -226,7 +226,7 @@ static const struct iio_buffer_setup_ops tiadc_buffer_setup_ops = {
>  	.postdisable = &tiadc_buffer_postdisable,
>  };
>  
> -int tiadc_iio_buffered_hardware_setup(struct iio_dev *indio_dev,
> +static int tiadc_iio_buffered_hardware_setup(struct iio_dev *indio_dev,
>  	irqreturn_t (*pollfunc_bh)(int irq, void *p),
>  	irqreturn_t (*pollfunc_th)(int irq, void *p),
>  	int irq,
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/