linux-kernel - [PATCH V2] kconfig/menu.c: fix uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1379869557-23116-1-git-send-email-maddy@linux.vnet.ibm.com>
Date:	Sun, 22 Sep 2013 22:35:57 +0530
From:	Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
To:	mmarek@...e.cz
Cc:	yann.morin.1998@...e.fr, bpoirier@...e.de,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
Subject: [PATCH V2] kconfig/menu.c: fix uninitialized variable warning

In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:586:18: warning: ‘jump’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
     jump->offset = r->len - 1;
                  ^
scripts/kconfig/menu.c:547:19: note: ‘jump’ was declared here
  struct jump_key *jump;
                   ^
Change V2:

1)Added comment as suggested.

Signed-off-by: Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
---
 scripts/kconfig/menu.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index c1d5320..32ee2d5 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -544,7 +544,8 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
 {
 	int i, j;
 	struct menu *submenu[8], *menu, *location = NULL;
-	struct jump_key *jump;
+	/* Initializing to avoid a spurious warning observed in gcc 4.8.0 */
+	struct jump_key *jump = NULL;
 
 	str_printf(r, _("Prompt: %s\n"), _(prop->text));
 	menu = prop->menu->parent;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/