linux-kernel - Re: [PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into account for conversion timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130922175145.GB27515@raspi>
Date:	Sun, 22 Sep 2013 19:51:46 +0200
From:	Matthias Kaehlcke <matthias.list@...hlcke.net>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Jonathan Cameron <jic23@....ac.uk>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Felipe Balbi <balbi@...com>,
	Pantelis Antoniou <panto@...oniou-consulting.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Arun Joseph <arunjoseph@...com>
Subject: Re: [PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into
 account for conversion timeout

Hi,

El Sat, Sep 21, 2013 at 01:25:42PM +0100 Jonathan Cameron ha dit:

> On 09/16/13 22:17, Matthias Kaehlcke wrote:
> > The calculation of the old conversion timeout value was based on the number of
> > steps used by this driver. This doesn't take into account that other steps
> > can be used by the touchscreen driver. Select the timeout value based on the
> > steps used by both drivers
> > 
> > Signed-off-by: Matthias Kaehlcke <matthias@...hlcke.net>
> Looks fine to me but I'd like an Ack from someone more familiar with the device
> if possible.

Arun, do you feel entitled to Ack or can you suggest someone from TI
who is?

> Also, I'm assuming this is a fix we want to push out asap but that isn't
> clear in your patch title.  Perhaps something like:
> 
> iio: ti_am335x_adc: Fix conversion timeout to allow for touch screen steps.
> ?

it's not as critical as it seems as in practice the timeout has the
granularity of a jiffy. If you prefer I still can resend the patch
with the subject you suggest

best regards

-- 
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam

             If God had not intended for us to eat animals,
                  how come He made them out of meat?
                           (Sarah Palin)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/