| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1379882338-7209-7-git-send-email-tytso@mit.edu> Date: Sun, 22 Sep 2013 16:38:52 -0400 From: Theodore Ts'o <tytso@....edu> To: Linux Kernel Developers List <linux-kernel@...r.kernel.org> Cc: hpa@...or.com, joern@...fs.org, macro@...ux-mips.org, ralf@...ux-mips.org, dave.taht@...il.com, blogic@...nwrt.org, andrewmcgr@...il.com, smueller@...onox.de, geert@...ux-m68k.org, tg@...bsd.de, Theodore Ts'o <tytso@....edu> Subject: [PATCH, RFC 06/12] random: optimize spinlock use in add_device_randomness() No point taking the spinlock twice for each call to mix_pool_bytes(); better to take it once for each pool where we add entropy. Signed-off-by: "Theodore Ts'o" <tytso@....edu> --- drivers/char/random.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index 391b05a..9564144 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -711,10 +711,15 @@ void add_device_randomness(const void *buf, unsigned int size) unsigned long flags; trace_add_device_randomness(size, _RET_IP_); - mix_pool_bytes(&input_pool, buf, size, NULL); - mix_pool_bytes(&input_pool, &time, sizeof(time), NULL); - mix_pool_bytes(&nonblocking_pool, buf, size, NULL); - mix_pool_bytes(&nonblocking_pool, &time, sizeof(time), NULL); + spin_lock_irqsave(&input_pool.lock, flags); + _mix_pool_bytes(&input_pool, buf, size, NULL); + _mix_pool_bytes(&input_pool, &time, sizeof(time), NULL); + spin_unlock_irqrestore(&input_pool.lock, flags); + + spin_lock_irqsave(&nonblocking_pool.lock, flags); + _mix_pool_bytes(&nonblocking_pool, buf, size, NULL); + _mix_pool_bytes(&nonblocking_pool, &time, sizeof(time), NULL); + spin_unlock_irqrestore(&nonblocking_pool.lock, flags); } EXPORT_SYMBOL(add_device_randomness); -- 1.7.12.rc0.22.gcdd159b -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists