linux-kernel - Re: [GIT PULL] Block IO fixes for 3.12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFygOYa1aCv02S04PvH+gfWi2GSKQ1PPcYTGVpz8UJs-eA@mail.gmail.com>
Date:	Sun, 22 Sep 2013 15:06:34 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>, Mike Christie <michaelc@...wisc.edu>
Subject: Re: [GIT PULL] Block IO fixes for 3.12

On Sun, Sep 22, 2013 at 2:55 PM, Jens Axboe <axboe@...nel.dk> wrote:
>
> Mike Christie (1):
>       If the queue is dying then we only call the rq->end_io callout.     This leaves bios setup on the request, because the caller assumes when     the blk_execute_rq_nowait/blk_execute_rq call has completed that     the rq->bios have been cleaned up.

Christ people.

We have rules for commit messages. Those rules have things like
"one-line commit summary at the top", because without that things like
summary logs (ie "git shortlog") and "gitk" don't do a good job.

How long have we been doing this? I'm used to seeing some odd commit
messages outside the kernel repo, but am used to kernel people getting
the trivial details right.

That's not the only one. Look at commit 577cee1e8db6 for some other
cruddy commit messages. Just because somebody said "Hello" in email
doesn't mean that it should remain that way in a commit message.

So out of seven commit messages, two were badly formatted. That's not
a sign of good quality control.

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/