linux-kernel - [PATCH] usb/core/devio.c:tolerate wrong direction flag in control endpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <523EC4BE.6000509@garloff.de>
Date:	Sun, 22 Sep 2013 12:21:50 +0200
From:	Kurt Garloff <kurt@...loff.de>
To:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.or
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [PATCH] usb/core/devio.c:tolerate wrong direction flag in control
 endpoints

Hi,

USB devio rejects control messages when the index does not have the
direction bit set correctly.
This breaks windows apps in KVM -- and might be overly strict according
to my reading of USB HID spec.
Attached patch makes the kernel tolerant against it and makes the app
work for me.

More details in the patch header.

USB experts: Please review this and judge whether this is correct,
applies more generically,
or maybe needs to be special cased (only for USB HID devices?) or
implemented as quirk
or module/kernel parameter.

Once in the final form, this *might* be stable material.

Please keep me in copy for the discussion, my participation on LKML is
mostly reading summaries
from Jonathan and Thorsten these days, unfortunately.

-- 
Kurt Garloff <kurt@...loff.de>
Cologne, Germany

View attachment "usb_devio_tolerate_wrong_ep_dir3.diff" of type "text/x-patch" (2976 bytes)