linux-kernel - Re: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130923074508.GF6247@mwanda>
Date:	Mon, 23 Sep 2013 10:45:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sonic Zhang <sonic.adi@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>, sfr@...b.auug.org.au,
	LKML <linux-kernel@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN
 in Kconfig.

The other two Coccinelle warnings were real bugs as well:

drivers/pinctrl/pinctrl-adi2.c:250:1-18: ERROR: nested lock+irqsave that reuses flags from line 249.
The second spinlock_irq_save() should just be a spinlock.

drivers/pinctrl/pinctrl-adi2.c:326:16-19: ERROR: port is NULL but dereferenced.
The error message dereferences a NULL pointer.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/