linux-kernel - Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874n9brj6y.fsf@sejong.aot.lge.com>
Date:	Mon, 23 Sep 2013 18:17:09 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

Hi Jiri,

On Sat, 21 Sep 2013 14:47:14 +0200, Jiri Olsa wrote:
> On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@....com>
>> 
>> Some files need additional compiler flags to be built successfully.
>> Cleanup Makefile by using optional per-file CFLAGS which look like
>> CFLAGS_dir_filename.o
>
> I like it, but I'm getting following error:
>
>   $ make 
>       ...
>       AR libperf.a
>   ar: util/rbtree.o: No such file or directory
>   make: *** [libperf.a] Error 1
>   $
>
> probably because rbtree object is based in kernel lib
>
>
> Also this patch collides with your previous:
>   perf tools: Separate out GTK codes to libperf-gtk.so
>
> which I needed to revert first to get this one applied.

Thanks for the feedback.  I'll take a look and fix them.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/