linux-kernel - Re: [PATCH -next] dma: mmp_pdma: use list_move instead of list_del/list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130923100253.GG17188@intel.com>
Date:	Mon, 23 Sep 2013 15:32:53 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	djbw@...com, grant.likely@...aro.org, rob.herring@...xeda.com,
	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH -next] dma: mmp_pdma: use list_move instead of
 list_del/list_add

On Mon, Sep 23, 2013 at 02:07:20PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Using list_move() instead of list_del() + list_add().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
Applied, thanks

~Vinod
> ---
>  drivers/dma/mmp_pdma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
> index ff8d7827..558994f 100644
> --- a/drivers/dma/mmp_pdma.c
> +++ b/drivers/dma/mmp_pdma.c
> @@ -798,8 +798,7 @@ static void dma_do_tasklet(unsigned long data)
>  		 * move the descriptors to a temporary list so we can drop
>  		 * the lock during the entire cleanup operation
>  		 */
> -		list_del(&desc->node);
> -		list_add(&desc->node, &chain_cleanup);
> +		list_move(&desc->node, &chain_cleanup);
>  
>  		/*
>  		 * Look for the first list entry which has the ENDIRQEN flag
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/