linux-kernel - Re: [PATCH] driver core: prevent deferred probe with platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130923110140.GB21013@sirena.org.uk>
Date:	Mon, 23 Sep 2013 12:01:40 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Johan Hovold <jhovold@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: prevent deferred probe with
 platform_driver_probe

On Mon, Sep 23, 2013 at 10:48:47AM +0200, Johan Hovold wrote:
> Prevent drivers relying on platform_driver_probe from requesting
> deferred probing in order to avoid further futile probe attempts (either
> the driver has been unregistered or its probe function has been set to
> platform_drv_probe_fail when probing is retried).
> 
> Note that several platform drivers currently return subsystem errors
> from probe and that these can include -EPROBE_DEFER (e.g. if a gpio
> request fails).

This doesn't seem like the right end to address the problem from, it
seems like it would be better to move these drivers over to being normal
plaform drivers.  Using module_platform_driver() means relying on init
ordering which is the sort of thing we're trying to get away from.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)