linux-kernel - Re: [PATCH] pinctrl: pinctrl-adi2: Remove nested lock+irqsave that resue flags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130923123822.GG6247@mwanda>
Date:	Mon, 23 Sep 2013 15:38:22 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sonic Zhang <sonic.adi@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH] pinctrl: pinctrl-adi2: Remove nested lock+irqsave that
 resue flags.

On Mon, Sep 23, 2013 at 05:29:48PM +0800, Sonic Zhang wrote:
> @@ -323,12 +323,12 @@ static unsigned int adi_gpio_irq_startup(struct irq_data *d)
>  	struct gpio_pint_regs *regs = port->pint->regs;
                                      ^^^^^^^^^^^^^^^^
Dereference.

>  
>  	if (!port) {
            ^^^^^
Too late to check here.

> -		dev_err(port->dev, "GPIO IRQ %d :Not exist\n", d->irq);
> +		pr_err("GPIO IRQ %d :Not exist\n", d->irq);
>  		return -ENODEV;
>  	}

regards,
dan carpenter
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/