linux-kernel - Re: checkpatch guide for newbies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVbjsg5g2or=g9k-W1KFd0HM4SN5uRWyMtZ9P_=aWhadg@mail.gmail.com>
Date:	Mon, 23 Sep 2013 16:04:50 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: checkpatch guide for newbies

On Mon, Sep 23, 2013 at 2:46 PM, Peter Senna Tschudin
<peter.senna@...il.com> wrote:
>> Ask yourself, is the warning message is clear?  Is it needed?  Could a

s/is clear/clear/

>> It's preferred if the operator goes at the end of the first line instead of at
>> the start of the second line:
>> Bad:
>> -       PowerData = (1 << 31) | (0 << 30) | (24 << 24)
>> -                   | BitReverse(w89rf242_txvga_data[i][0], 24);
>> Good:
>> +       PowerData = (1 << 31) | (0 << 30) | (24 << 24) |
>> +                   BitReverse(w89rf242_txvga_data[i][0], 24);
> What is the rule for where to start the second line here?

Either aligned to the equivalent part on the previous line (i.e. "BitReverse" is
aligned with "(1 << 31)"), or one indent step more than the beginning of the
first line (i.e. "BitReverse" is indented by one more TAB tjan "PowerData").

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/