lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Sep 2013 10:56:27 -0400 From: Jeff Moyer <jmoyer@...hat.com> To: Vaughan Cao <vaughan.cao@...cle.com> Cc: axboe@...nel.dk, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] block: register_blkdev doesn't check name against NULL Vaughan Cao <vaughan.cao@...cle.com> writes: > register_blkdev(0, NULL) can result kernel Oops by copying from NULL > in strlcpy(). Fix it by checking NULL pointer at the beginning and > WARN when encountered in unregister_blkdev. Uhh, so yeah, this is an exported function, so I could see maybe wanting to do the argument checking. But honestly, if your driver can't even get this right, is there any hope of it actually working? This seems like a pointless patch to me, but ultimately it's up to Jens. Cheers, Jeff p.s. the kerneldoc tells you what to put there: * @name: the name of the new block device as a zero terminated string -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists