linux-kernel - Re: [PATCH] regulator: core: Always use return value when regulator_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130923151956.GA22941@ulmo>
Date:	Mon, 23 Sep 2013 17:20:20 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	linaro-kernel@...ts.linaro.org, Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH] regulator: core: Always use return value when
 regulator_dev_lookup() fails

On Mon, Sep 23, 2013 at 04:14:43PM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@...aro.org>
> 
> Ensure that the return value is always set when we return now that the
> logic has changed for regulator_get_optional() so we don't get missing
> codes leaking out.
> 
> Reported-by: Thierry Reding <treding@...dia.com>
> Signed-off-by: Mark Brown <broonie@...aro.org>
> ---
>  drivers/regulator/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index fabbf32..6333080 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1281,12 +1281,13 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>  	if (rdev)
>  		goto found;
>  
> +	regulator = ERR_PTR(ret);
> +
>  	/*
>  	 * If we have return value from dev_lookup fail, we do not expect to
>  	 * succeed, so, quit with appropriate error value
>  	 */
>  	if (ret && ret != -ENODEV) {
> -		regulator = ERR_PTR(ret);
>  		goto out;
>  	}

Perhaps remove the { and } now that there's only the "goto out;" left?

Tested-by: Thierry Reding <treding@...dia.com>

Content of type "application/pgp-signature" skipped