linux-kernel - Re: [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523FB773.4050408@roeck-us.net>
Date:	Sun, 22 Sep 2013 20:37:23 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	Fan Rong <cinifr@...il.com>, coosty@....com,
	daniel.lezcano@...aro.org, linux@....linux.org.uk,
	tglx@...utronix.de, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, mark.rutland@....com,
	pawel.moll@....co, rob.herring@...xeda.com,
	linux-sunxi@...glegroups.com
Subject: Re: [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i).

On 09/21/2013 07:00 AM, Maxime Ripard wrote:

[ ... ]

>> +	/* assert cpu core reset */
>> +	writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
>> +	/* L1RSTDISABLE hold low */
>> +	pwr_reg = readl(sunxi7i_cc_base + AW_CPUCFG_GENCTL);
>> +	pwr_reg &= ~(1<<cpu);
>> +	writel(pwr_reg, sunxi7i_cc_base + AW_CPUCFG_GENCTL);
>> +	/* DBGPWRDUP hold low */
>> +	pwr_reg = readl(sunxi7i_cc_base + AW_CPUCFG_DBGCTL1);
>> +	pwr_reg &= ~(1<<cpu);
>
> Use BIT(cpu) here. And you should run scripts/checkpatch.pl on your
> patches before sending them.
>

For the record:

$ scripts/checkpatch.pl --strict allwinner.patch
total: 0 errors, 0 warnings, 0 checks, 527 lines checked

allwinner.patch has no obvious style problems and is ready for submission.

This is on top of "v3.12-rc1-336-gd8524ae".

checkpatch.pl does not complain as long as the number of spaces before
and after an operator is the same. There is a patch pending to change
this with the --strict option, but it will still not complain in 'normal'
operation.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/