linux-kernel - Re: [RFC][PATCH 0/3] FS-Cache: NFS(/CIFS/Ceph/9P): Fix start-caching whilst writing race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP1eJFH234+98DORsQub+6kXuuYfN93=bCjVK8Q5gMWbohtCg@mail.gmail.com>
Date:	Mon, 23 Sep 2013 13:00:55 -0400
From:	Milosz Tanski <milosz@...in.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Trond Myklebust <Trond.Myklebust@...app.com>, steved@...hat.com,
	linux-cifs@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"linux-cachefs@...hat.com" <linux-cachefs@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	ceph-devel <ceph-devel@...r.kernel.org>
Subject: Re: [RFC][PATCH 0/3] FS-Cache: NFS(/CIFS/Ceph/9P): Fix start-caching
 whilst writing race

This should not be a problem with Ceph as the MDS (the metadata
server) hands out cache capability bit for an inode. In this schema
there's no need to worry about the count of of local file pointers
open for write (or even across the cluster).

As an aside, the Ceph code checks if we can perform the requested VMA
operation by checking the valid_fscache generation (compared to the
current cache generation). This way we only create the cookie the
first time the file is open. This has greatly simplified the code and
got rid of a lot of races.

Best,
- Milosz

On Fri, Sep 20, 2013 at 11:09 AM, David Howells <dhowells@...hat.com> wrote:
>
>
> Following this mail is a series of patches to fix an issue with NFS whereby
> caching can be enabled on a file that is open for writing by subsequently
> opening it for reading.  This can be made to crash by opening it for writing
> again if you're quick enough.
>
> The patches mailed here may not apply directly.  They are based on top of three
> fix patches as can be seen in the GIT branch here:
>
>   http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache
>
>
> The gist of the patchset is that the cookie should be acquired at inode
> creation only and subsequently enabled and disabled as appropriate (which
> dispenses with the backing objects when they're not needed).
>
> The extra synchronisation that NFS does can then be dispensed with as it is
> thenceforth managed by FS-Cache.
>
> This likely will need applying to CIFS, Ceph and 9P also once this is okayed
> for NFS.  AFS is probably safe.
>
> David
> ---
> David Howells (3):
>       FS-Cache: Add use/unuse/wake cookie wrappers
>       FS-Cache: Provide the ability to enable/disable cookies
>       NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open()
>
>
>  Documentation/filesystems/caching/netfs-api.txt |   73 +++++++--
>  fs/9p/cache.c                                   |    6 -
>  fs/afs/cell.c                                   |    2
>  fs/afs/inode.c                                  |    2
>  fs/afs/vlocation.c                              |    3
>  fs/afs/volume.c                                 |    2
>  fs/cachefiles/interface.c                       |    2
>  fs/ceph/cache.c                                 |    4
>  fs/cifs/fscache.c                               |    8 -
>  fs/fscache/cookie.c                             |  193 +++++++++++++++++------
>  fs/fscache/fsdef.c                              |    1
>  fs/fscache/netfs.c                              |    1
>  fs/fscache/object.c                             |    7 +
>  fs/fscache/page.c                               |   59 +++++--
>  fs/nfs/dir.c                                    |    2
>  fs/nfs/fscache.c                                |  196 +++++++----------------
>  fs/nfs/fscache.h                                |   18 +-
>  fs/nfs/inode.c                                  |    6 -
>  fs/nfs/nfs4file.c                               |    2
>  include/linux/fs.h                              |    5 +
>  include/linux/fscache-cache.h                   |   50 ++----
>  include/linux/fscache.h                         |  113 ++++++++++++-
>  include/linux/nfs_fs.h                          |    8 +
>  23 files changed, 462 insertions(+), 301 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/