linux-kernel - Re: [PATCH 03/13] tpm: xen-tpmfront: Fix default durations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52408F0C.4020107@tycho.nsa.gov>
Date:	Mon, 23 Sep 2013 14:57:16 -0400
From:	Daniel De Graaf <dgdegra@...ho.nsa.gov>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	david.vrabel@...rix.com, boris.ostrovsky@...cle.com,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Ashley Lai <ashley@...leylai.com>,
	Rajiv Andrade <mail@...jiv.net>,
	Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Sirrix AG <tpmdd@...rix.com>, Peter Huewe <peterhuewe@....de>
Subject: Re: [PATCH 03/13] tpm: xen-tpmfront: Fix default durations

On 09/23/2013 02:51 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Sep 23, 2013 at 12:14:33PM -0600, Jason Gunthorpe wrote:
>> All the default durations were being set to 10 minutes which is
>> way too long for the timeouts. Normal values for the longest
>> duration are around 5 mins, and short duration ar around .5s.
>>
>> Further, these are just the default, tpm_get_timeouts will set
>> them to values from the TPM (or throw an error).
>>
>> Just remove them.
>
> Sounds sensible.
>
> Daniel?

Also sounds good to me. I believe this was just a remnant of the old
xen-tpmfront code that didn't get removed once the timeouts were being
read from the backend.

>>
>> Cc: Daniel De Graaf <dgdegra@...ho.nsa.gov>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>> Signed-off-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
>> ---
>>   drivers/char/tpm/xen-tpmfront.c | 7 -------
>>   1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
>> index 7a7929b..6f2fe2b 100644
>> --- a/drivers/char/tpm/xen-tpmfront.c
>> +++ b/drivers/char/tpm/xen-tpmfront.c
>> @@ -210,8 +210,6 @@ static struct attribute_group vtpm_attr_grp = {
>>   	.attrs = vtpm_attrs,
>>   };
>>
>> -#define TPM_LONG_TIMEOUT   (10 * 60 * HZ)
>> -
>>   static const struct tpm_vendor_specific tpm_vtpm = {
>>   	.status = vtpm_status,
>>   	.recv = vtpm_recv,
>> @@ -224,11 +222,6 @@ static const struct tpm_vendor_specific tpm_vtpm = {
>>   	.miscdev = {
>>   		.fops = &vtpm_ops,
>>   	},
>> -	.duration = {
>> -		TPM_LONG_TIMEOUT,
>> -		TPM_LONG_TIMEOUT,
>> -		TPM_LONG_TIMEOUT,
>> -	},
>>   };
>>
>>   static irqreturn_t tpmif_interrupt(int dummy, void *dev_id)
>> --
>> 1.8.1.2
>>
>
>


-- 
Daniel De Graaf
National Security Agency
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/