linux-kernel - Re: [PATCH] usb: dwc3: Remove additional delay of 100ms when resuming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Sep 2013 15:26:44 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Vivek Gautam' <gautam.vivek@...sung.com>
Cc:	linux-usb@...r.kernel.org,
	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	'Felipe Balbi' <balbi@...com>, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] usb: dwc3: Remove additional delay of 100ms when resuming

On Monday, September 23, 2013 12:38 PM, Vivek Gautam wrote:
> 
> This delay got introduced in:
> "7415f17 usb: dwc3: core: add power management support"
> which reflected similar code in dwc3_core_soft_reset() function.
> However, originally the delay of 100ms in dwc3_core_soft_reset() was
> meant to assist USB2PHY and USB3PHY reset, not for usb_phy_init()
> sequence.
> 
> We should get rid of this delay, since things will still work
> fine without this.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>

Reviewed-by: Jingoo Han <jg1.han@...sung.com>

OK, I see.
There is no reason to add msleep(100) to dwc3_resume();
thus, this msleep(100) can be removed.

Best regards,
Jingoo Han

> ---
> 
> Hi Felipe,
> 
> I remember this change for phy_init including msleep(100) was
> suggested by me, after testing the patch-series for PM support
> to dwc3.
> Sorry for that !!
> 
>  drivers/usb/dwc3/core.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 474162e..e88ffae 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -691,7 +691,6 @@ static int dwc3_resume(struct device *dev)
> 
>  	usb_phy_init(dwc->usb3_phy);
>  	usb_phy_init(dwc->usb2_phy);
> -	msleep(100);
> 
>  	spin_lock_irqsave(&dwc->lock, flags);
> 
> --
> 1.7.6.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/