linux-kernel - Re: [PATCH -next] drivers: CCI: fix the error handle in cci_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130924093222.GC15119@mudshark.cambridge.arm.com>
Date:	Tue, 24 Sep 2013 10:32:22 +0100
From:	Will Deacon <will.deacon@....com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"nico@...aro.org" <nico@...aro.org>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	"dave.martin@...aro.org" <dave.martin@...aro.org>,
	Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@....com>,
	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH -next] drivers: CCI: fix the error handle in
 cci_pmu_probe()

On Sun, Sep 22, 2013 at 06:04:23AM +0100, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> This patch fix the error handle of function cci_pmu_probe():
> - using IS_ERR() instead of NULL test for the return value of
>   devm_ioremap_resource() since it nerver return NULL.
> - remove kfree() for devm_kzalloc allocated memory
> - remove dev_warn() since devm_ioremap_resource() has error message
>   already.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Cheers Wei, I'll add this as a new patch on top of my perf branch.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/